[no-relnote] Test multiple driver branches during E2E #1201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArangoGutierrez
added
the
testing
ArangoGutierrez
commented
Jul 21, 2025
ArangoGutierrez
force-pushed
the
multiple_drivers_e2e
branch
from
40b572a to
a4b8b66
Compare
Pull Request Test Coverage Report for Build 16420617111Details
💛 - Coveralls |
elezar
reviewed
Jul 21, 2025
.github/workflows/e2e.yaml
Outdated
| aws_secret_access_key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} | ||
| aws_ssh_key: ${{ secrets.AWS_SSH_KEY }} | ||
| holodeck_config: "tests/e2e/infra/aws.yaml" | ||
| holodeck_config: ${{ matrix.holodeck_file }} |
Member
There was a problem hiding this comment.
Suggested change
| holodeck_config: ${{ matrix.holodeck_file }} | |
| holodeck_config: tests/e2e/infra/aws_${{ matrix.variant }} |
elezar
reviewed
Jul 21, 2025
.github/workflows/e2e.yaml
Outdated
| - variant: EOL | ||
| holodeck_file: tests/e2e/infra/aws_EOL.yaml | ||
| - variant: LATEST | ||
| holodeck_file: tests/e2e/infra/aws_LATEST.yaml |
elezar
reviewed
Jul 21, 2025
.github/workflows/e2e.yaml
Outdated
| exclude: | ||
| - variant: EOL | ||
| ispr: true |
Member
There was a problem hiding this comment.
I would rather run against an older driver on PRs and LATEST on main.
ArangoGutierrez
force-pushed
the
multiple_drivers_e2e
branch
6 times, most recently
from
dfaf0f6 to
2ba86e7
Compare
ArangoGutierrez
changed the title
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
ArangoGutierrez
force-pushed
the
multiple_drivers_e2e
branch
from
2ba86e7 to
7af2955
Compare
elezar
reviewed
Jul 21, 2025
| name: ginkgo-logs-${{ matrix.driver_branch }} | ||
| path: ginkgo.json | ||
| retention-days: 15 | ||
| - name: Send Slack alert notification |
Member
There was a problem hiding this comment.
Nit: Did we also want to include the driver branch in the Slack message?
Collaborator
Author
There was a problem hiding this comment.
Good idea!
elezar
approved these changes
Jul 21, 2025
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
There was a problem hiding this comment.
Pull Request Overview
This pull request enhances the end-to-end (E2E) testing workflow by introducing a matrix strategy to test multiple driver branches (550 and 575) instead of the previous single infrastructure variant approach. The changes include conditional execution logic to skip driver branch 575 for pull request events while allowing both branches to run on other events.
- Added matrix strategy to test driver branches 550 and 575 with conditional execution
- Created new driver branch-specific configuration file for branch 575
- Updated job names, configuration paths, and artifact names to reflect the driver branch being tested
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/e2e/infra/driver-branch-575.yaml | New configuration file for driver branch 575 with infrastructure specifications |
| .github/workflows/e2e.yaml | Updated workflow to use matrix strategy for multiple driver branches with conditional execution |
Comments suppressed due to low confidence (1)
.github/workflows/e2e.yaml:42
- The matrix variable name 'is_pull_request' is misleading as it actually represents the inverse - whether it's NOT a pull request. Consider renaming to 'is_not_pull_request' or 'run_all_branches' for clarity.
is_pull_request:
elezar
reviewed
Jul 21, 2025
| strategy: | ||
| matrix: | ||
| is_pull_request: | ||
| - ${{!( startsWith(github.ref, 'refs/pull/') )}} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances the end-to-end (E2E) testing workflow by introducing a matrix strategy for testing multiple infrastructure variants (EOL and LATEST) and updating the associated configuration files. The changes aim to improve flexibility and maintainability in the E2E testing process.
Workflow Enhancements:
.github/workflows/e2e.yaml: Added a matrix strategy to test both EOL and LATEST infrastructure variants, with conditional execution to skip the EOL variant for pull request events. Updated job names, Holodeck configuration, and artifact names to reflect the variant being tested. [1] [2] [3]Infrastructure Configuration Updates:
tests/e2e/infra/aws_EOL.yaml: Renamed fromaws.yamland modified to reflect the EOL variant setup by removing theimageIdfield.tests/e2e/infra/aws_LATEST.yaml: Added a new configuration file for the LATEST infrastructure variant, specifying details such as instance type, region, ingress IP ranges, and NVIDIA driver installation.