-
Notifications
You must be signed in to change notification settings - Fork 435
[no-relnote] Test multiple driver branches during E2E #1201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -37,6 +37,16 @@ on: | |
| jobs: | ||
| e2e-tests: | ||
| runs-on: linux-amd64-cpu4 | ||
| strategy: | ||
| matrix: | ||
| is_pull_request: | ||
| - ${{!( startsWith(github.ref, 'refs/pull/') )}} | ||
| driver_branch: | ||
| - 550 | ||
| - 575 | ||
| exclude: | ||
| - is_pull_request: true | ||
ArangoGutierrez marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| driver_branch: 575 | ||
| steps: | ||
| - name: Check out code | ||
| uses: actions/checkout@v4 | ||
|
|
@@ -54,21 +64,21 @@ jobs: | |
| with: | ||
| go-version: ${{ env.GOLANG_VERSION }} | ||
|
|
||
| - name: Set up Holodeck | ||
| - name: Set up Holodeck (${{ matrix.driver_branch }}) | ||
| uses: NVIDIA/holodeck@v0.2.13 | ||
| with: | ||
| aws_access_key_id: ${{ secrets.AWS_ACCESS_KEY_ID }} | ||
| aws_secret_access_key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} | ||
| aws_ssh_key: ${{ secrets.AWS_SSH_KEY }} | ||
| holodeck_config: "tests/e2e/infra/aws.yaml" | ||
| holodeck_config: tests/e2e/infra/driver-branch-${{ matrix.driver_branch }}.yaml | ||
|
|
||
| - name: Get public dns name | ||
| id: holodeck_public_dns_name | ||
| uses: mikefarah/yq@master | ||
| with: | ||
| cmd: yq '.status.properties[] | select(.name == "public-dns-name") | .value' /github/workspace/.cache/holodeck.yaml | ||
|
|
||
| - name: Run e2e tests | ||
| - name: Run e2e tests (${{ matrix.driver_branch }}) | ||
| env: | ||
| E2E_INSTALL_CTK: "true" | ||
| E2E_IMAGE_NAME: ghcr.io/nvidia/container-toolkit | ||
|
|
@@ -86,9 +96,10 @@ jobs: | |
| - name: Archive Ginkgo logs | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: ginkgo-logs | ||
| name: ginkgo-logs-${{ matrix.driver_branch }} | ||
| path: ginkgo.json | ||
| retention-days: 15 | ||
|
|
||
| - name: Send Slack alert notification | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: Did we also want to include the driver branch in the Slack message?
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good idea!
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done |
||
| if: ${{ failure() }} | ||
| uses: slackapi/slack-github-action@v2.1.1 | ||
|
|
@@ -98,6 +109,6 @@ jobs: | |
| payload: | | ||
| channel: ${{ secrets.SLACK_CHANNEL_ID }} | ||
| text: | | ||
| :x: On repository ${{ github.repository }}, the Workflow *${{ github.workflow }}* has failed. | ||
| :x: On repository ${{ github.repository }}, the Workflow *${{ github.workflow }}-driver-branch-${{ matrix.driver_branch }}* has failed. | ||
|
|
||
| Details: https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }} | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| apiVersion: holodeck.nvidia.com/v1alpha1 | ||
| kind: Environment | ||
| metadata: | ||
| name: HOLODECK_NAME | ||
| description: "end-to-end test infrastructure" | ||
| spec: | ||
| provider: aws | ||
| auth: | ||
| keyName: cnt-ci | ||
| privateKey: HOLODECK_PRIVATE_KEY | ||
| instance: | ||
| type: g4dn.xlarge | ||
| region: us-west-1 | ||
| ingressIpRanges: | ||
| - 18.190.12.32/32 | ||
| - 3.143.46.93/32 | ||
| - 44.230.241.223/32 | ||
| - 44.235.4.62/32 | ||
| - 52.15.119.136/32 | ||
| - 52.24.205.48/32 | ||
| image: | ||
| architecture: amd64 | ||
| containerRuntime: | ||
| install: true | ||
| name: docker | ||
| nvidiaContainerToolkit: | ||
| install: false | ||
| nvidiaDriver: | ||
| install: true | ||
| branch: 575 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question: Why the
!?