Don't read cdi generate mode from runtime mode #1377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although there is overlap, the runtime modes (auto, legacy, csv, cdi, jit-cdi, wsl) are not directly usable as nvidia-ctk cdi generate modes as these don't include (legacy, cdi, jit-cdi). This change removes reading the CDI generate mode from the config file as this prevents automatic CDI spec generation in cases where a user has updated their config to override the mode (e.g. explicitly set it to legacy or cdi). Signed-off-by: Evan Lezar <elezar@nvidia.com>
|
/cherry-pick release-1.18 |
ArangoGutierrez
approved these changes
Oct 23, 2025
|
/cherry-pick release-1.18 |
|
🤖 Backport PR created for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although there is overlap, the runtime modes (auto, legacy, csv, cdi, jit-cdi, wsl) are not directly usable as nvidia-ctk cdi generate modes as these don't include (legacy, cdi, jit-cdi).
This change removes reading the CDI generate mode from the config file as this prevents automatic CDI spec generation in cases where a user has updated their config to override the mode (e.g. explicitly set it to legacy or cdi).
This changes the behaviour added in #1107.
Fixes #1376