Disable nvsandboxutils by default #1419
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change disables the use of nvsandboxuitls for CDI spec generation by default. This prevents issues with specific (end-of-life) driver versions where consecutive calls would cause a cgo segmentation violation that could not be recovered from. The EnableNvsandboxutils feature flag can be specified when generating CDI specs (or instantiating the nvcdi API) to explicitly opt-in to using the nvsandboxutils library. Signed-off-by: Evan Lezar <elezar@nvidia.com>
|
/cherry-pick release-1.18 |
elezar
requested review from
ArangoGutierrez,
cdesiniotis,
jgehrcke and
tariq1890
This change allows users the posibility to explicitly specify feature flags for using the `jit-cdi` mode. This allows, for example, for users to opt-in to use nvsandboxutils in the default mode in addition to when generating CDI specs explicitly. Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
force-pushed
the
make-nvsandbox-utils-opt-in
branch
from
b025a99 to
4ea22c5
Compare
| // FeatureDisableNvsandboxUtils disables the use of nvsandboxutils when | ||
| // querying devices. | ||
| // | ||
| // Deprecated: nvsandboxutils is now disabled by default. To opt-in use the |
There was a problem hiding this comment.
Do we have a policy on how long to keep a deprecated feature before total removal?
There was a problem hiding this comment.
No we don't.
For this feature specifically, I know that @jgehrcke mentioned using this while working on the dynamic MIG for DRA.
ArangoGutierrez
approved these changes
Nov 5, 2025
elezar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change switches to making
nvsandboxutilsopt-in when generating CDI specs. Furthermore, and explicit config option is provided to allow nvcdi features to be specified when using the (now default)jit-cdimode.Fixes #1398
These changes will also need to be pulled in to the device plugin.
To opt-in to this feature for the
jit-cdimode, run:To opt-in for
nvidia-ctk cdi generaterun:To opt-in for the
nvidia-cdi-refresh.serviceadd:to
/etc/nvidia-container-toolkit/nvidia-cdi-refresh.env.