[no-relnote] Run golang checks on PRs #1510
Merged
+10
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArangoGutierrez
approved these changes
Dec 3, 2025
Pull Request Test Coverage Report for Build 19888361331Details
💛 - Coveralls |
Collaborator
|
We need to set all golang tests to github managed runners as part of this PR |
elezar
force-pushed
the
run-golang-checks-on-prs
branch
from
0cec30d to
4fd5177
Compare
Member
Author
Could you elaborate? The tests are already using |
elezar
force-pushed
the
run-golang-checks-on-prs
branch
2 times, most recently
from
b2ff7cc to
56c84fe
Compare
This change enables golang checks on PRs (e.g. by dependabot). This provides basic checks for minimal dependency bumps without requiring an /ok-to-test by a maintainer. Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
force-pushed
the
run-golang-checks-on-prs
branch
from
56c84fe to
d541925
Compare
ArangoGutierrez
approved these changes
Dec 3, 2025
| build: | ||
| name: Build | ||
| runs-on: linux-amd64-cpu4 | ||
| runs-on: ${{ ( github.event_name == 'pull_request' ) && 'ubuntu-latest' || 'linux-amd64-cpu4' }} |
Collaborator
|
Is it a good idea to back port this to 1.18? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables golang checks on PRs (e.g. by dependabot). This provides basic checks for minimal dependency bumps without requiring an /ok-to-test by a maintainer.