Add --device-id flag to nvidia-ctk cdi generate command #1512
+15
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows device IDs to be specified when generating CDI specs using the nvidia-ctk cdi generate CDI. The command now accepts a (repeatable) CLI flag allowing device IDs to be specified. These can be indices or uuids. The devices IDs can also be specified as a comma-separated list using the NVIDIA_CTK_CDI_GENERATE_DEVICE_IDS environment variable. Signed-off-by: Evan Lezar <elezar@nvidia.com>
Pull Request Test Coverage Report for Build 19896104216Details
💛 - Coveralls |
| for _, tc := range testCases { | ||
| // Apply overrides for all test cases: | ||
| tc.options.nvidiaCDIHookPath = "/usr/bin/nvidia-cdi-hook" | ||
| if tc.options.deviceIDs == nil { |
Collaborator
There was a problem hiding this comment.
should we add a test case for a bad/dummy/good device id?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows device IDs to be specified when generating CDI specs using
the nvidia-ctk cdi generate CDI. The command now accepts a (repeatable) CLI
flag allowing device IDs to be specified. These can be indices or uuids.