Rename test folder to tests #873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArangoGutierrez
force-pushed
the
tests_rename
branch
2 times, most recently
from
16770bf to
be3666c
Compare
elezar
reviewed
Jan 22, 2025
|
|
||
| for _, f := range files { | ||
| inputSpecPath := filepath.Join(moduleRoot, "test/input", f) | ||
| inputSpecPath := filepath.Join(moduleRoot, "tests/input", f) |
Member
There was a problem hiding this comment.
out of scope for this PR, but we should consider moving this to testdata.
Collaborator
Author
There was a problem hiding this comment.
I'll do as a follow up to this PR
elezar
requested changes
Jan 22, 2025
Member
elezar
left a comment
elezar
left a comment
There was a problem hiding this comment.
I think you forgot to delete the existing folder.
ArangoGutierrez
force-pushed
the
tests_rename
branch
from
be3666c to
beb8cc5
Compare
Collaborator
Author
Thanks for noticing, I have removed the folder, but I am confused, I did a simple |
ArangoGutierrez
force-pushed
the
tests_rename
branch
2 times, most recently
from
e7d7e0e to
53fbdc1
Compare
elezar
approved these changes
Jan 23, 2025
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com> Signed-off-by: Evan Lezar <elezar@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the
testfolder toteststo be in line with other project conventions