release: Fix new sigstore format and update VERIFY.md #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zvonko Kaiser <zkaiser@nvidia.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the release documentation and workflow by removing support for the two-flavor build system (NVRC and NVRC-confidential variants) and updating to the new sigstore bundle format for verifying the Rekor CLI.
Changes:
- Removed all references to the two-flavor build system (NVRC vs NVRC-confidential) from VERIFY.md
- Updated workflow to use new
.sigstore.jsonbundle format instead of separate.pemand.sigfiles - Improved documentation formatting with multi-line commands and corrected workflow filename reference
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| VERIFY.md | Removed BIN variable and two-flavor references, hardcoded NVRC binary name, improved command formatting, and corrected workflow filename from .yml to .yaml |
| .github/workflows/release.yaml | Updated Rekor CLI verification to use new .sigstore.json bundle format, removed conditional logic for old/new formats, and updated step name to reflect actual installation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
release: Fix new sigstore format and update VERIFY.md