Remove cc release #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zvonko Kaiser <zkaiser@nvidia.com>
zvonkok
force-pushed
the
remove-cc-release
branch
from
b7f661a to
bce9e84
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the confidential computing (CC) flavor from the release pipeline, simplifying the build matrix to only produce standard NVRC binaries. The changes streamline the release workflow by eliminating the --features=confidential build variant and consolidating artifact naming.
Key changes:
- Removed "nvidia" kernel module loading from main initialization sequence
- Added
cat()utility function for debugging generated configuration files - Simplified GitHub Actions release workflow from 4 matrix combinations to 2 (removed flavor dimension)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/main.rs | Removed nvidia module loading, keeping only nvidia-uvm |
| src/coreutils.rs | Added cat() function for reading and logging file contents with associated tests |
| src/toolkit.rs | Integrated cat() to debug CDI spec generation output |
| .github/workflows/release.yaml | Removed confidential flavor from build matrix, simplified artifact naming from ${bin}-${target} to NVRC-${target}, updated verification scripts to match new naming scheme |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we do not build CC flavour anymore remove if from the release. Mean and lean.