fix: relax dependency constraints to support Python 3.13#48
Open
ThanhNguyxn wants to merge 1 commit intoNVIDIA:mainfrom
Open
fix: relax dependency constraints to support Python 3.13#48ThanhNguyxn wants to merge 1 commit intoNVIDIA:mainfrom
ThanhNguyxn wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Fixes NVIDIA#22 Changes: - Remove upper bound on torch (>= 2.2.0) to allow torch 2.5+ which has wheels for Python 3.13 - Relax other dependency constraints that were unnecessarily strict: - numpy: >= 1.26, < 3 (was < 2.2) - safetensors: >= 0.4.0 (removed < 0.5) - huggingface-hub: >= 0.24 (removed < 0.25) - einops: >= 0.7 (was == 0.7) - sentencepiece: >= 0.2 (was == 0.2) - sounddevice: >= 0.5 (was == 0.5) - sphn: >= 0.1.4 (removed < 0.2) - aiohttp: >= 3.10.5 (removed < 3.11) These changes ensure compatibility with Python 3.13 while maintaining backward compatibility with Python 3.10-3.12. The previous torch < 2.5 constraint was the root cause of the issue, as PyTorch only added CPython 3.13 wheel support starting from v2.5.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #22 - Current PyTorch dependencies don't work with CPython 3.13
Problem
The previous
pyproject.tomlhadtorch >= 2.2.0, < 2.5which prevented installation on Python 3.13 because PyTorch only added CPython 3.13 wheel support starting from v2.5.0.Solution
Relaxed dependency constraints to support Python 3.13 while maintaining backward compatibility with Python 3.10-3.12:
>= 2.2.0, < 2.5>= 2.2.0>= 1.26, < 2.2>= 1.26, < 3>= 0.4.0, < 0.5>= 0.4.0>= 0.24, < 0.25>= 0.24== 0.7>= 0.7== 0.2>= 0.2== 0.5>= 0.5>= 0.1.4, < 0.2>= 0.1.4>= 3.10.5, < 3.11>= 3.10.5Why These Changes Are Safe
Testing
This change enables installation on Python 3.13 by allowing pip to resolve torch 2.5+ which has the required wheels.
Backward Compatibility
✅ Fully backward compatible - no breaking changes for Python 3.10-3.12 users.