Update Omniverse USD performance tuning skill#180
Conversation
|
/nvskills-ci |
6404bc6 to
b0a5954
Compare
|
Update: this branch now includes the generated |
Signed-off-by: Jens Jebens <jjebens@nvidia.com>
b0a5954 to
ed276a1
Compare
|
Thanks for the review. I rebased this branch onto current |
|
Ran the exact sanity check requested on the current PR head |
mosheabr
left a comment
There was a problem hiding this comment.
Approving — apologies for the false alarm in my earlier review. I was looking at gh pr view --json files output which truncated at 100 files (GitHub API default), and the canonical-path updates for skill-card.md, skill.oms.sig, references/usd-validation-runner/*, and references/workflow.md were on the second page so I didn't see them.
Re-verified directly via the contents API:
- Canonical
skill-card.mdSHA4671d60(≠ main48d29eb) — updated ✓ - Canonical
skill.oms.sigSHAbd9e75a(≠ main5aaecdb) — updated ✓ - Canonical ↔ plugin both at SHA
4671d60/bd9e75a— byte-for-byte identical ✓ - Validate Plugins CI passing —
build-plugins.py --checkreturns no drift ✓
Good content refresh — Phase-4 target coverage, fail-closed reconciliation, structured validator concepts, the new validate_report.py and usd_validation_executor.py scripts all look solid. Thanks for the patient walk-through on plugins/ being the curated bundle.
Onboarding type
components.d/<slug>.ymlfile)For new product onboarding — author affirmations
By submitting this PR, I confirm on behalf of my team:
.agents/skills/orskills/path used for new entries (or existing path retained for legacy entries percomponents.d/<slug>.yml)Reviewer checklist (OSS Skills PIC)
components.d/<slug>.ymlentry valid (required fields, uniquecatalog_dir, path exists in source repo, filename slug matches name)SKILL.mdfrontmatter spec-compliant (at least one sampled)All PRs
git commit -s).If you forgot, run
git rebase --signoff origin/main && git push --force-with-leaseto retroactively sign all commits in your branch.Other context (for non-onboarding PRs)
This updates the existing
omniverse-usd-performance-tuningskill in the canonical NVIDIA skills catalog from the merged Physical AI skill hub copy.This is a patch update for the existing Omniverse manual catalog entry. It brings over the latest USD performance tuning workflow, refreshed validation/reporting references, updated eval metadata, the generated
BENCHMARK.md, refreshedskill-card.md, and refreshedskill.oms.sigfrom the skill hub NVSkills run.The patch substantially improves the skill's performance workflow by adding stronger Phase-4 target coverage, fail-closed reconciliation behavior, clearer validation-runner guidance, structured validator concepts, and report validation fixtures/scripts.
Validation run locally:
git diff --checkskills/omniverse-usd-performance-tuning/**/*.jsonpython3 skills/omniverse-usd-performance-tuning/references/optimization-report/scripts/validate_report.py skills/omniverse-usd-performance-tuning/references/report-templates/optimization-report.design-fixture.json --manifest skills/omniverse-usd-performance-tuning/references/report-templates/optimization-report.design-fixture.manifest.jsonpython3 skills/omniverse-usd-performance-tuning/references/optimization-report/scripts/validate_report.py skills/omniverse-usd-performance-tuning/references/report-templates/optimization-report.structural-only-fixture.jsonpython3 -m py_compile skills/omniverse-usd-performance-tuning/references/optimization-report/scripts/validate_report.py skills/omniverse-usd-performance-tuning/references/usd-validation-runner/scripts/usd_validation_executor.pyNVIDIA-dev/physical-ai-skill-hub-dev@009a77b:skills/omniverse-usd-performance-tuning