Adding cuda-quantum's cudaq-guide skill#7
Conversation
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
|
The job failure is expected as the PR in cuda-quantum repo needs to be merged in. |
|
@mosheabr May I please request you to review this PR? |
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
mosheabr
left a comment
mosheabr
left a comment
There was a problem hiding this comment.
Looks good — clean one-liner that follows the existing pattern exactly.
A couple of notes:
-
Upstream blocker — Since this depends on NVIDIA/cuda-quantum#4229 landing first, CI will fail until that merges. We can leave this open and merge once the upstream PR is in. Just flagging so it doesn't get merged prematurely.
-
README update — The other products are listed in the catalog README. Should we add CUDA-Q there too, or are you planning that as a follow-up?
Otherwise LGTM — happy to approve once the upstream PR lands.
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
Thanks @mosheabr. The upstream PR #4229 has landed. Have updated README here. Seems like the job is failing. We just have 1 skill. |
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
mosheabr
left a comment
mosheabr
left a comment
There was a problem hiding this comment.
LGTM — thanks for updating the README too, Sachin. The CI, links, and table entries all look correct.
The CI failure you're seeing is a pre-existing Megatron-Core drift (they added a 3rd skill). That's being fixed in #9 — once it merges, CI here should go green.
Should we add logic to dynamically update these files in order to avoid these failures? Else your team will have to keep track of which skills have been added/deleted. |
CUDA-Q was merged into the catalog (NVIDIA#7). Add checkout + copy block for NVIDIA/cuda-quantum → skills/CUDA-Q. Signed-off-by: Sayali Kandarkar <skandarkar@nvidia.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
CUDA-Q was merged into the catalog (#7). Add checkout + copy block for NVIDIA/cuda-quantum → skills/CUDA-Q. Signed-off-by: Sayali Kandarkar <skandarkar@nvidia.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2 participants
Adding cuda-quantum's cudaq-guide skill
Blocked on NVIDIA/cuda-quantum#4229 getting merged in the main repo.