fix!: make imagePullSecret optional to prevent kubelet errors#155
Merged
fix!: make imagePullSecret optional to prevent kubelet errors#155
Conversation
BREAKING CHANGE: imagePullSecret now defaults to empty string instead of "node-init-secret" Previously, imagePullSecret defaulted to "node-init-secret" which caused kubelet to log errors when the secret didn't exist. This change makes the secret truly optional: - chart/values.yaml: Change default from "node-init-secret" to "" - chart/templates/deployment.yaml: Only add imagePullSecrets when set - operator/internal/controller/skyhook_controller.go: Remove default value and conditionally add ImagePullSecrets to pods - operator/config/manager/manager.yaml: Remove hardcoded secret - Update documentation with migration instructions Users pulling from private registries must now explicitly set imagePullSecret in their Helm values. Users with public images (default ghcr.io) need no changes.
lockwobr
requested review from
ayuskauskas,
mskalka and
riceriley59
as code owners
riceriley59
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: imagePullSecret now defaults to empty string instead of "node-init-secret"
Previously, imagePullSecret defaulted to "node-init-secret" which caused kubelet to log errors when the secret didn't exist. This change makes the secret truly optional:
Users pulling from private registries must now explicitly set imagePullSecret in their Helm values. Users with public images (default ghcr.io) need no changes.