Conversation
this brings back a recent change that was made to priority.
lockwobr
force-pushed
the
gated-sequencing
branch
2 times, most recently
from
fb3de95 to
0bdd1b7
Compare
lockwobr
force-pushed
the
gated-sequencing
branch
14 times, most recently
from
36a79b5 to
5451524
Compare
learned that putting many assert in one file were happening in parallel, and not sequential as i thought, this was causing the flapping tests. additionally not the same, when order matters. cleaned up all the places where we were using chainsaw assert incorrectly.
lockwobr
force-pushed
the
gated-sequencing
branch
from
5451524 to
1f4f32c
Compare
lockwobr
requested review from
ayuskauskas,
mskalka and
riceriley59
as code owners
ayuskauskas
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sequencingfield to Skyhook spec with two modes:node(default, per-node ordering) andall(global gate requiring all nodes to complete before any proceed to the next priority)sequencing: allcreates cluster-wide synchronization points in the priority chainsequencing: nodepreserves existing per-node behavior where healthy nodes progress independentlynodefor most, drop inallwhere cluster-wide sync is neededsequencing: allwithruntimeRequired: true