fix(agent): change to a secondary chroot_exec so it happens in a diff… #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erent process Due to distroless we can't do a subprocess.run(chroot /root [cmd]) So instead we call a separate python process to chroot inside of. If we do the chroot inside controller the chroot last for the rest of the process which causes issues with file management and other things that happen after the call.
lockwobr
reviewed
Jul 8, 2025
lockwobr
reviewed
Jul 8, 2025
lockwobr
reviewed
Jul 8, 2025
lockwobr
reviewed
Jul 9, 2025
lockwobr
approved these changes
Jul 9, 2025
|
Can you please squash all these commits on merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…erent process
Due to distroless we can't do a subprocess.run(chroot /root [cmd]) So instead we call a separate python process to chroot inside of. If we do the chroot inside controller the chroot last for the rest of the process which causes issues with file management and other things that happen after the call.