Instantiate the debug sender inside connect() #1070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccotter
force-pushed
the
debug-completion-sigs
branch
2 times, most recently
from
26758d3 to
6ff2d9c
Compare
ccotter
force-pushed
the
debug-completion-sigs
branch
from
6ff2d9c to
09f435b
Compare
ericniebler
reviewed
Sep 8, 2023
Collaborator
|
/ok to test |
Collaborator
I can't think of a reason why this would be problematic in principle. |
ccotter
commented
Sep 10, 2023
| continuation_kernel<<<1, 1, 0, op.stream_>>>(std::move(op.rec_), stdexec::set_value); | ||
| } else { | ||
| continuation_kernel<cudaError_t><<<1, 1, 0, op.stream_>>>( | ||
| continuation_kernel<<<1, 1, 0, op.stream_>>>( |
Contributor
Author
There was a problem hiding this comment.
Some of the refactors of continuation_kernel which reordered the template parameters seem to have missed this one. The first template parameter is Receiver.
Collaborator
There was a problem hiding this comment.
I'm pulling this change out into its own commit, since it's unrelated.
Collaborator
|
/ok to test |
Collaborator
|
/ok to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't build with clang-16, but does with gcc-12. Is there any reason conceptually we shouldn't be able to check the actual vs expected completions within
connect?