Bug: static_thread_pool::get_scheduler_on_thread causes SegFault#1465
Merged
ericniebler merged 2 commits intoNVIDIA:mainfrom Jan 22, 2025
Merged
Conversation
added 2 commits
January 7, 2025 11:22
nodemask_ is not initialized when get_scheduler_on_thread is called. Test case fails without the fix.
Collaborator
|
/ok to test |
Collaborator
|
thank you @DavidElesTheFox ! |
Contributor
Author
|
Thank you :), it's always a pleasure to collaborate! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
nodemask_is not initialized whenget_scheduler_on_threadis called on astatic_thread_poolDetails
A new test is added. I haven't find existing tests for the
static_thread_pool, thought starting one can be handy for later.The test case creates a new pool and try to start tasks on different thread indexes. It fails with segmentation fault without the fix because the member pointer is not initialized.
With the fix we can observe that the pool scheduled tasks on different threads.