fix a bad test for async_scope::spawn_future#1491
Merged
ericniebler merged 2 commits intomainfrom Mar 17, 2025
Merged
Conversation
the test was relying on a bug in the implementation of `__tuple`, which this commit also fixes. finally, it fixes a bug in the implementation of `starts_on` that causes `terminate` to be called if moving the sender throws.
ericniebler
force-pushed
the
fix-spawn-future-test
branch
from
72dbb93 to
e46f8ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the test was relying on a bug in the implementation of
__tuple, which this commit also fixes. finally, it fixes a bug in the implementation ofstarts_onthat causesterminateto be called if moving the sender throws.