[execpools,asio] add executor getter to be able to schedule asio functions#1535
Merged
ericniebler merged 2 commits intoNVIDIA:mainfrom Jun 5, 2025
Merged
[execpools,asio] add executor getter to be able to schedule asio functions#1535ericniebler merged 2 commits intoNVIDIA:mainfrom
ericniebler merged 2 commits intoNVIDIA:mainfrom
Conversation
3423434 to
97ec2b5
Compare
Collaborator
|
/ok to test 97ec2b5 |
ericniebler
reviewed
May 21, 2025
Collaborator
ericniebler
left a comment
There was a problem hiding this comment.
thanks for the PR! i have one small naming question.
mathisloge
added a commit
to mathisloge/quite
that referenced
this pull request
May 22, 2025
Collaborator
|
/ok to test fa52e97 |
ericniebler
approved these changes
May 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the asiothread pool can be only used with the senders. However e.g. an asio timer always needs some execution context.
By adding a getter for the executor of the thread pool, one can use both APIs together as the example test shows