Skip to content

[execpools,asio] add executor getter to be able to schedule asio functions#1535

Merged
ericniebler merged 2 commits intoNVIDIA:mainfrom
mathisloge:feature/asio_interop
Jun 5, 2025
Merged

[execpools,asio] add executor getter to be able to schedule asio functions#1535
ericniebler merged 2 commits intoNVIDIA:mainfrom
mathisloge:feature/asio_interop

Conversation

@mathisloge
Copy link
Copy Markdown
Contributor

Currently the asiothread pool can be only used with the senders. However e.g. an asio timer always needs some execution context.
By adding a getter for the executor of the thread pool, one can use both APIs together as the example test shows

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented May 19, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@mathisloge mathisloge force-pushed the feature/asio_interop branch from 3423434 to 97ec2b5 Compare May 19, 2025 20:33
@ericniebler
Copy link
Copy Markdown
Collaborator

/ok to test 97ec2b5

Copy link
Copy Markdown
Collaborator

@ericniebler ericniebler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR! i have one small naming question.

Comment thread include/execpools/asio/asio_thread_pool.hpp Outdated
Comment thread test/execpools/test_asio_thread_pool.cpp Outdated
mathisloge added a commit to mathisloge/quite that referenced this pull request May 22, 2025
@mathisloge mathisloge requested a review from ericniebler May 22, 2025 18:03
@ericniebler
Copy link
Copy Markdown
Collaborator

/ok to test fa52e97

@ericniebler ericniebler merged commit 47185ef into NVIDIA:main Jun 5, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants