Fix include style in exec/sequence.hpp#1589
Merged
ericniebler merged 1 commit intoNVIDIA:mainfrom Jul 26, 2025
Merged
Conversation
The header `exec/sequence.hpp` has always used the `< >` style for includes,
e.g. `#include <stdexec/execution.hpp>`. This doesn't work with NVC++.
But that hasn't been a problem in practice because none of the examples
or tests seem to have included `exec/sequence.hpp`. But a few days ago
`exec/repeat_n.hpp` and `exec/repeat_effect_until.hpp` were both changed
to have `#include "sequence.hpp"`. That broke many of the NVC++ tests
for stdexec with
```
".../sequence.hpp", line 18: catastrophic error: cannot open source file "stdexec/execution.hpp"
#include <stdexec/execution.hpp>
^
```
Fix the failures by changing `exec/sequence.hpp` to use relative
includes in quotes rather than `< >`. This fixes the NVC++ tests.
Collaborator
|
/ok to test df819ce |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The header
exec/sequence.hpphas always used the< >style for includes, e.g.#include <stdexec/execution.hpp>. This doesn't work with NVC++. But that hasn't been a problem in practice because none of the examples or tests seem to have includedexec/sequence.hpp. But a few days agoexec/repeat_n.hppandexec/repeat_effect_until.hppwere both changed to have#include "sequence.hpp". That broke many of the NVC++ tests for stdexec withFix the failures by changing
exec/sequence.hppto use relative includes in quotes rather than< >. This fixes the NVC++ tests.