Mark __opstate classes as final instead of adding virtual destructors#1801
Merged
ericniebler merged 1 commit intoNVIDIA:mainfrom Jan 29, 2026
Merged
Mark __opstate classes as final instead of adding virtual destructors#1801ericniebler merged 1 commit intoNVIDIA:mainfrom
ericniebler merged 1 commit intoNVIDIA:mainfrom
Conversation
ericniebler
requested changes
Jan 28, 2026
Collaborator
ericniebler
left a comment
There was a problem hiding this comment.
my preference would be to make the __opstate class final rather than adding a bunch of vtable entries that won't be used.
Signed-off-by: Jan Ciesko <jan.ciesko@gmail.com>
Contributor
Author
|
Good point |
b1b30cd to
b444fb8
Compare
Contributor
Author
|
Updated. |
ericniebler
approved these changes
Jan 29, 2026
Collaborator
|
/ok to test b444fb8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
virtualmodifiers to destructors in virtual classes.clang++16.[1]