tests(stdexec): fix and test demangling utility#1873
Merged
ericniebler merged 2 commits intoNVIDIA:mainfrom Feb 22, 2026
Merged
tests(stdexec): fix and test demangling utility#1873ericniebler merged 2 commits intoNVIDIA:mainfrom
ericniebler merged 2 commits intoNVIDIA:mainfrom
Conversation
ericniebler
reviewed
Feb 20, 2026
|
|
||
| template <class _Sexpr, class _Receiver> | ||
| extern __declfn_t<::STDEXEC::__opstate<__demangle_t<_Sexpr>, _Receiver>> | ||
| __demangle_v<::STDEXEC::__opstate<_Sexpr, _Receiver>>; |
Collaborator
There was a problem hiding this comment.
demangling is only for sender types
Contributor
Author
There was a problem hiding this comment.
OK, reverted.
| namespace __detail { | ||
| template <class _Tag, class _Data, class... _Child> | ||
| using __basic_sender_t = __basic_sender<_Tag, _Data, __demangle_t<_Child>...>::type; | ||
| using __basic_sender_t = __basic_sender<_Tag, _Data, __demangle_t<_Child>...>; |
Collaborator
There was a problem hiding this comment.
i added ::type recently as a necessary bit of ADL isolation. what problem is it causing?
Contributor
Author
There was a problem hiding this comment.
I just found it weird that the reported demangled type looks like STDEXEC::__basic_sender<...>::type. But I've reverted the change.
Signed-off-by: romintomasetti <romin.tomasetti@gmail.com>
romintomasetti
force-pushed
the
demangle
branch
from
84279d0 to
59f04ae
Compare
Contributor
Author
|
@ericniebler I've addressed your comments, this PR now only adds a test, does not touch anything else. |
Collaborator
|
/ok to test 59f04ae |
Collaborator
|
/ok to test 1a37225 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.