Skip to content

Fix use-after-move in stdexec::spawn #1983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericniebler merged 1 commit into from
Apr 2, 2026
+5 −5
Merged

Fix use-after-move in stdexec::spawn #1983

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions include/stdexec/__detail/__spawn.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,18 +135,18 @@ namespace STDEXEC
auto __wrapped_sender = __tkn.wrap(static_cast<_Sender&&>(__sndr));
auto __sndr_env = get_env(__wrapped_sender);

using __raw_alloc = decltype(__spawn_common::__choose_alloc(__env, __sndr_env));
auto __raw_alloc = __spawn_common::__choose_alloc(__env, __sndr_env);
using __raw_alloc_t = decltype(__raw_alloc);

auto __sender_with_env = write_env(std::move(__wrapped_sender),
__spawn_common::__choose_senv(__env, __sndr_env));

using __spawn_state_t =
__spawn_state<__raw_alloc, std::remove_cvref_t<_Token>, decltype(__sender_with_env)>;
__spawn_state<__raw_alloc_t, std::remove_cvref_t<_Token>, decltype(__sender_with_env)>;

using __traits =
std::allocator_traits<__raw_alloc>::template rebind_traits<__spawn_state_t>;
typename __traits::allocator_type __alloc(
__spawn_common::__choose_alloc(__env, __sndr_env));
std::allocator_traits<__raw_alloc_t>::template rebind_traits<__spawn_state_t>;
typename __traits::allocator_type __alloc(__raw_alloc);

auto* __op = __traits::allocate(__alloc, 1);

Expand Down
Loading