Skip to content

Fix incorrect template instantiation in inline_task_context (#2012) #2013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericniebler merged 2 commits into from
Apr 10, 2026
+8 −5
Merged

Fix incorrect template instantiation in inline_task_context (#2012) #2013

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ab0aa8
Fix incorrect template instantiation in inline_task_context (#2012)
SamGaaWaa Apr 10, 2026
a51b6d0
Apply suggestion from @ericniebler
ericniebler Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions include/exec/task.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,12 +117,15 @@ namespace experimental::execution
template <class _ParentPromise>
constexpr explicit __default_task_context_impl(_ParentPromise& __parent) noexcept
{
if constexpr (__with_affinity && __parent_promise_has_start_scheduler<_ParentPromise>())
if constexpr (__with_affinity)
{
// get_start_scheduler is used here to get the parent's "current" scheduler,
// which is the one on which this task has been started (i.e., co_await-ed).
auto __parent_sched = get_start_scheduler(get_env(__parent));
this->__scheduler_ = __parent_sched;
if constexpr (__parent_promise_has_start_scheduler<_ParentPromise>())
{
// get_start_scheduler is used here to get the parent's "current" scheduler,
// which is the one on which this task has been started (i.e., co_await-ed).
auto __parent_sched = get_start_scheduler(get_env(__parent));
this->__scheduler_ = __parent_sched;
}
Comment thread
ericniebler marked this conversation as resolved.
}
}

Expand Down
Loading