Skip to content
This repository was archived by the owner on Mar 21, 2024. It is now read-only.

Update openmp check.#1386

Merged
alliepiper merged 1 commit intoNVIDIA:mainfrom
alliepiper:nvcxx_omp_check
Feb 22, 2021
Merged

Update openmp check.#1386
alliepiper merged 1 commit intoNVIDIA:mainfrom
alliepiper:nvcxx_omp_check

Conversation

@alliepiper
Copy link
Copy Markdown
Collaborator

No description provided.

@alliepiper alliepiper added the testing: gpuCI in progress Started gpuCI testing. label Feb 19, 2021
@alliepiper alliepiper added this to the 1.12.0 milestone Feb 19, 2021
@alliepiper
Copy link
Copy Markdown
Collaborator Author

run tests

@alliepiper alliepiper added testing: gpuCI passed Passed gpuCI testing. and removed testing: gpuCI in progress Started gpuCI testing. labels Feb 19, 2021
@dkolsen-pgi
Copy link
Copy Markdown
Collaborator

That's definitely the right change. But the name of the new macro hasn't been finalized yet. I will wait to approve the PR to see if the name changes, though I won't wait more than a couple days.

@alliepiper
Copy link
Copy Markdown
Collaborator Author

Sounds good. I'm okay with merging this between the RC and the release if needed, so early next week would be fine.

@alliepiper alliepiper added the testing: internal ci in progress Currently testing on internal NVIDIA CI (DVS). label Feb 19, 2021
@alliepiper
Copy link
Copy Markdown
Collaborator Author

DVS CL: 29629947

@alliepiper
Copy link
Copy Markdown
Collaborator Author

@dkolsen-pgi Have you decided on a final name for this?

@alliepiper alliepiper added testing: internal ci passed Passed internal NVIDIA CI (DVS). and removed testing: internal ci in progress Currently testing on internal NVIDIA CI (DVS). labels Feb 22, 2021
@dkolsen-pgi
Copy link
Copy Markdown
Collaborator

Let's go with _NV_STDPAR_OPENMP. I haven't made a final decision about names, but there is a good chance that one will fit into whatever pattern we settle on.

@alliepiper alliepiper merged commit e1eb836 into NVIDIA:main Feb 22, 2021
@alliepiper alliepiper deleted the nvcxx_omp_check branch February 22, 2021 22:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

testing: gpuCI passed Passed gpuCI testing. testing: internal ci passed Passed internal NVIDIA CI (DVS).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants