This repository was archived by the owner on Mar 21, 2024. It is now read-only.
[NVBug 3308316] Update deprecation messages for CTK 11.4.#1430
Merged
alliepiper merged 1 commit intoNVIDIA:1.12.Xfrom May 18, 2021
Merged
[NVBug 3308316] Update deprecation messages for CTK 11.4.#1430alliepiper merged 1 commit intoNVIDIA:1.12.Xfrom
alliepiper merged 1 commit intoNVIDIA:1.12.Xfrom
Conversation
alliepiper
added
P0: must have
Bug 3308316
alliepiper
force-pushed
the
update_depr_messages
branch
from
d406cce to
4380744
Compare
|
|
||
| // Compiler checks: | ||
| # if THRUST_HOST_COMPILER == THRUST_HOST_COMPILER_GCC && THRUST_GCC_VERSION < 50000 | ||
| THRUST_COMPILER_DEPRECATION(GCC 5.0, upgrade your compiler); |
Collaborator
There was a problem hiding this comment.
Why do we no longer say "upgrade your compiler"?
Collaborator
Author
There was a problem hiding this comment.
The message was getting too long and awkward with the requested additions, and upgrade your compiler is redundant with your compiler is deprecated so I dropped it.
brycelelbach
approved these changes
May 18, 2021
Collaborator
brycelelbach
left a comment
brycelelbach
left a comment
There was a problem hiding this comment.
Looks fine mostly, curious why we dropped "upgrade your compiler" but I can live with it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is going into the
1.12.Xside branch for the CTK-11.4-specificThrust 1.12.1release.