Skip to content
This repository was archived by the owner on Mar 21, 2024. It is now read-only.

[gpuCI] Clear stale CMake files and report failures.#1435

Merged
alliepiper merged 1 commit intoNVIDIA:mainfrom
alliepiper:report_gpuci_failures
May 20, 2021
Merged

[gpuCI] Clear stale CMake files and report failures.#1435
alliepiper merged 1 commit intoNVIDIA:mainfrom
alliepiper:report_gpuci_failures

Conversation

@alliepiper
Copy link
Copy Markdown
Collaborator

@alliepiper alliepiper commented May 13, 2021

I noticed that gcc-5 has been failing for some time, but was reported as passing. This is because the build failures were in CUDA targets, but only non-CUDA tests are run on the cpu testers and the builder would only fail if the testing step failed.

Now it checks the configure, build, and test steps explicitly and logs a summary of which steps failed at the end of the output. Now gcc-5 reports as failing:

>>>> Summary:
>>>> - Configure Error Code: 0
>>>> - Build Error Code: 1
>>>> - Test Error Code: 0

@alliepiper alliepiper added the only: gpuci Changes to gpuCI only. Doesn't need internal NVIDIA CI. label May 13, 2021
@alliepiper alliepiper added this to the 1.13.0 milestone May 13, 2021
@alliepiper
Copy link
Copy Markdown
Collaborator Author

run tests

@alliepiper
Copy link
Copy Markdown
Collaborator Author

@brycelelbach this fixes the build script so that gcc-5 now shows as failing. We were missing these because the tests still passed, even though there were build errors.

@alliepiper alliepiper merged commit 8c34b4d into NVIDIA:main May 20, 2021
@alliepiper alliepiper deleted the report_gpuci_failures branch May 20, 2021 20:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

only: gpuci Changes to gpuCI only. Doesn't need internal NVIDIA CI.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants