docs: post-#254 follow-ups — KEP-4962 note + Doc-Impact table rows#278
Conversation
Adds a short subsection under `## Labels` covering KEP-4962
("Standardizing the Representation of Cluster Network Topology"),
which is pre-GA and still under upstream review at
kubernetes/enhancements#4962 (draft PR #4965). Notes that the KEP's
framing allows vendor prefixes like `network.topology.nvidia.com/*`
to coexist with the standard `topology.kubernetes.io/` keys rather
than replace them, and that Topograph will evaluate aligning or
providing both if and when the KEP reaches GA. For now, the
`network.topology.nvidia.com/*` keys remain authoritative for
Topograph-deployed clusters.
This note was deferred from PR NVIDIA#264 because the target file
(`docs/reference/node-labels.md`) did not yet exist on `main`; it
was introduced by PR NVIDIA#254, which merged 2026-04-19.
Signed-off-by: Rob Esker <resker@nvidia.com>
Adds back two rows to the Documentation Impact Evaluation table in `AGENTS.md` and `.claude/CLAUDE.md` that were removed from PR NVIDIA#269 to avoid cross-referencing content not yet on `main`: - Chart template row pointing at `docs/engines/k8s.md` "Exposing the Topograph API" section (added to main by PR NVIDIA#259) - Label or annotation key row pointing at `docs/reference/node-labels.md` (added to main by PR NVIDIA#254) Both gating PRs have now merged, so the rows can be restored without broken cross-references. Paired edit preserves the byte-identical invariant between `AGENTS.md` and `.claude/CLAUDE.md` from line 6 onward (verified with `cmp`). Signed-off-by: Rob Esker <resker@nvidia.com>
Greptile SummaryThis documentation-only PR adds a KEP-4962 upstream-alignment note to Confidence Score: 5/5Safe to merge — documentation-only changes with no code impact. All three files contain purely additive documentation; no logic, API contracts, or labels are modified. The AGENTS.md / CLAUDE.md sync invariant is maintained, cross-references resolve, and there are no P0/P1 findings. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["AGENTS.md\n(Doc-Impact table +2 rows)"] -- "byte-identical sync (lines 6+)" --> B[".claude/CLAUDE.md\n(Doc-Impact table +2 rows)"]
C["docs/reference/node-labels.md\n(KEP-4962 subsection added)"]
B -- "row: New / changed label key →" --> C
A -- "row: New / changed label key →" --> C
D["docs/engines/k8s.md\n('Exposing the Topograph API' section)"]
B -- "row: New / changed chart template →" --> D
A -- "row: New / changed chart template →" --> D
Reviews (1): Last reviewed commit: "docs(agents): restore two Doc-Impact Eva..." | Re-trigger Greptile |
Description
Two small follow-ups that became unblocked by PR #254 (
docs(reference): add authoritative node labels and annotations reference) merging tomainearlier today. Both were previously documented as "pending #254 merge" in session notes; bundled here as a single, minimal PR.1. KEP-4962 upstream-alignment note (
docs/reference/node-labels.md)Adds a short subsection under
## Labelscovering KEP-4962: Standardizing the Representation of Cluster Network Topology (draft in PR #4965). The note establishes that:network.topology.nvidia.com/*keys predate any upstream standard and are presently vendor-scoped.topology.kubernetes.io/keys to coexist, not replace one another.This content was originally queued for PR #264 but deferred because the target file (
docs/reference/node-labels.md) didn't exist onmainuntil #254 landed.2. Doc-Impact Evaluation table: restore two rows (
AGENTS.md+.claude/CLAUDE.md)Adds back two rows removed from PR #269 to avoid broken cross-references to content not yet on
main:docs/engines/k8s.md"Exposing the Topograph API" sectiondocs/reference/node-labels.mdBoth target sections now exist on
main:docs/reference/node-labels.mdwas added by PR docs(reference): add authoritative node labels and annotations reference #254.Paired edit preserves the byte-identical invariant between
AGENTS.mdand.claude/CLAUDE.mdfrom line 6 onward, verified with:Commits
Two logical commits on this branch, one per change:
docs(reference): add KEP-4962 upstream-alignment note to node-labels.mddocs(agents): restore two Doc-Impact Evaluation table rowsChecklist
git commit -s).