Fix verbose flag in capture_debug_dot_print function#1202
Fix verbose flag in capture_debug_dot_print function#1202shi-eric merged 1 commit intoNVIDIA:mainfrom
capture_debug_dot_print function#1202Conversation
Signed-off-by: liblaf <30631553+liblaf@users.noreply.github.com>
📝 WalkthroughWalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile OverviewGreptile SummaryFixed a logic bug in the
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant Python as capture_debug_dot_print()
participant Native as wp_capture_debug_dot_print()
participant CUDA as cudaGraphDebugDotPrint()
User->>Python: capture_debug_dot_print(graph, path, verbose=True)
Note over Python: Before fix: 0 if verbose else 1<br/>After fix: 1 if verbose else 0
Python->>Native: wp_capture_debug_dot_print(graph, path, 1)
Native->>CUDA: cudaGraphDebugDotPrint(graph, path, flags=1)
Note over CUDA: flags=1 enables verbose output<br/>flags=0 disables verbose output
CUDA-->>Native: success
Native-->>Python: true
Python-->>User: success
|
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the capture_debug_dot_print function where the verbose flag was inverted, causing the opposite behavior to what was intended. When users requested verbose output, they got non-verbose output and vice versa.
Changes:
- Fixed inverted boolean logic in the call to
wp_capture_debug_dot_print(now correctly passes1for verbose,0for non-verbose) - Updated default value of
verboseparameter fromFalsetoTrueto maintain backward compatibility with the actual behavior users experienced
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description
Correct verbose flag in
capture_debug_dot_printfunction. Default value ofverboseis changed to keep the default behavior consistent.Before your PR is "Ready for review"
__init__.pyi,docs/api_reference/,docs/language_reference/)pre-commit run -a