Fix links and cg example in documentation.#1245
Conversation
Signed-off-by: Charlie Latimer <clatimer159@gmail.com>
📝 WalkthroughWalkthroughThree files updated with documentation improvements: CHANGELOG.md adds entries for documentation enhancements, sparse.rst updates a Conjugate Gradient API usage example with corrected keyword arguments, and an init.py docstring receives formatting improvements for Sphinx role references. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR fixes documentation issues including correcting the
Confidence Score: 5/5
Important Files Changed
Last reviewed commit: 8746415 |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
CHANGELOG.md (1)
136-137: Consider adding GitHub issue references.Both new entries lack
([GH-XXX](...))links. Per project guidelines, CHANGELOG entries should include issue refs where one exists.📝 Proposed fix
-- Add missing links to docstrings across the API Reference. -- Update documentation examples for calls to `wp.optim.linear.cg`. +- Add missing links to docstrings across the API Reference ([GH-XXX](https://github.com/NVIDIA/warp/issues/XXX)). +- Update documentation examples for calls to `wp.optim.linear.cg` ([GH-XXX](https://github.com/NVIDIA/warp/issues/XXX)).Based on learnings: "Applies to CHANGELOG.md : Use imperative present tense in CHANGELOG.md ('Add X', not 'Added X' or 'This adds X'). Include issue refs: (GH-XXX). Avoid internal implementation details users wouldn't understand."
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@CHANGELOG.md` around lines 136 - 137, Update the two CHANGELOG entries ("Add missing links to docstrings across the API Reference." and "Update documentation examples for calls to `wp.optim.linear.cg`.") to include the corresponding GitHub issue references in the format ([GH-XXX](https://github.com/NVIDIA/warp/issues/XXX)); replace XXX with the actual issue numbers where they exist and leave entries unchanged otherwise, ensuring the entries remain in imperative present tense.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@CHANGELOG.md`:
- Around line 136-137: Update the two CHANGELOG entries ("Add missing links to
docstrings across the API Reference." and "Update documentation examples for
calls to `wp.optim.linear.cg`.") to include the corresponding GitHub issue
references in the format ([GH-XXX](https://github.com/NVIDIA/warp/issues/XXX));
replace XXX with the actual issue numbers where they exist and leave entries
unchanged otherwise, ensuring the entries remain in imperative present tense.
|
Thanks for the docs fixes, @clatim! In the future, minor typo fixes should not be noted in the changelog, but I'll fix this post-merge in this instance. |
Description
Update some of the examples in the documentation, and fix some links.
Before your PR is "Ready for review"
__init__.pyi,docs/api_reference/,docs/language_reference/)pre-commit run -aSummary by CodeRabbit