Fix crash consistency issue with alternate logs (#100)#109
Merged
Andiry merged 1 commit intoNVSL:masterfrom Jul 18, 2021
Merged
Fix crash consistency issue with alternate logs (#100)#109Andiry merged 1 commit intoNVSL:masterfrom
Andiry merged 1 commit intoNVSL:masterfrom
Conversation
…n main and alter logs after crash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has a fix for the crash consistency bug described in issue #100. The issue could occur if the system crashed between initializing an inode's main and alternate logs. In the current version of NOVA, the inode's checksum is updated after the main log is initialized and again after the alternate log is initialized. Crashing between these updates can lead to a state where NOVA assumes that both logs are initialized, causing incorrect behavior. This fix moves the checksum update to occur after initialization of both logs, which prevents this issue.