Skip to content

PMD GIS Groundwork#2304

Merged
alexrichey merged 3 commits intomainfrom
ar-add-metadata-destination-version
Apr 9, 2026
Merged

PMD GIS Groundwork#2304
alexrichey merged 3 commits intomainfrom
ar-add-metadata-destination-version

Conversation

@alexrichey
Copy link
Copy Markdown
Contributor

@alexrichey alexrichey commented Apr 2, 2026

A little groundwork before getting started implementing the GIS packaging flow in the product-metadata repo.

Commit 1: current_version

Adds a current_version field, which can be set at a product, dataset, or destination level. This is what GIS would set to kick off distribution

Commit 2: Moves Product Metadata into it's own folder under dcpy

No actual code changes, just changes to references. The rationale is that the core of the product-metadata functionality is too low-level for dcpy.lifecycle.package, which should really just be configuration - sort of "wiring things together". I'd also like pmd (product-metadata) to be installable with just something like uv pip install dcpy[product-metadata], which brings me to.

Commit 3: pyproject.toml optional dependency for pmd

For the moment, this is more to document the required python packages required for pmd. If we were to refactor deps, this would enable uv pip install dcpy[product-metadata] to just install pmd reqs. At the moment, it will install all dcpy reqs.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 2, 2026

Codecov Report

❌ Patch coverage is 93.61702% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.79%. Comparing base (ac51241) to head (07b9897).

Files with missing lines Patch % Lines
dcpy/lifecycle/package/_cli.py 0.00% 1 Missing ⚠️
dcpy/lifecycle/package/esri.py 0.00% 1 Missing ⚠️
dcpy/models/lifecycle/distribute.py 0.00% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
dcpy/connectors/edm/open_data_nyc.py 61.03% <100.00%> (ø)
dcpy/connectors/edm/product_metadata.py 52.63% <100.00%> (ø)
dcpy/connectors/esri/arcgis_feature_service.py 88.61% <100.00%> (ø)
dcpy/connectors/socrata/metadata.py 86.84% <100.00%> (ø)
dcpy/connectors/socrata/publish.py 62.92% <100.00%> (ø)
dcpy/lifecycle/ingest/transform.py 89.38% <ø> (ø)
dcpy/lifecycle/package/assemble.py 56.25% <100.00%> (+0.30%) ⬆️
dcpy/lifecycle/package/shapefiles.py 93.15% <100.00%> (ø)
dcpy/lifecycle/package/validate.py 72.10% <100.00%> (ø)
dcpy/lifecycle/product_metadata.py 100.00% <100.00%> (ø)
... and 13 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alexrichey alexrichey force-pushed the ar-add-metadata-destination-version branch from b1e05d2 to 89c9b38 Compare April 2, 2026 17:42
@alexrichey alexrichey requested a review from damonmcc April 8, 2026 14:45
@alexrichey alexrichey marked this pull request as ready for review April 8, 2026 14:47
@alexrichey alexrichey force-pushed the ar-add-metadata-destination-version branch from b62930c to af8b804 Compare April 8, 2026 15:00
@alexrichey alexrichey marked this pull request as draft April 8, 2026 15:05
@alexrichey alexrichey changed the title add destination version PMD GIS Groundwork Apr 8, 2026
@alexrichey alexrichey force-pushed the ar-add-metadata-destination-version branch 3 times, most recently from 1b8845e to ec7d442 Compare April 8, 2026 15:44
@alexrichey alexrichey marked this pull request as ready for review April 8, 2026 16:02
@alexrichey alexrichey marked this pull request as draft April 8, 2026 16:14
@alexrichey alexrichey force-pushed the ar-add-metadata-destination-version branch 4 times, most recently from 1a2aec6 to ab3a3bc Compare April 8, 2026 17:21
@alexrichey alexrichey force-pushed the ar-add-metadata-destination-version branch from ab3a3bc to 07b9897 Compare April 8, 2026 17:43
@alexrichey alexrichey marked this pull request as ready for review April 8, 2026 17:57
@alexrichey alexrichey merged commit 9f2c137 into main Apr 9, 2026
26 checks passed
@alexrichey alexrichey deleted the ar-add-metadata-destination-version branch April 9, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants