This repository was archived by the owner on Apr 11, 2022. It is now read-only.
Remove lane identifier#713
Merged
Merged
Conversation
… we don't need to make people come up with an identifier separate from the display name.
aslagle
approved these changes
Nov 9, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch removes the
Lane.identifierfield, which was a unique ID that was also supposed to be human-readable. Not many humans actually see these values (they're used in URLs and that's about it) and it was unnecessary to make admins come up with two different names for each lane, one of which has to be unique and one of which doesn't.The new
full_identifierproperty is only supposed to be used in things like log statements.