Scc 5291/is research#93
Merged
Merged
Conversation
Contributor
charmingduchess
commented
Apr 21, 2026
charmingduchess
commented
- add isResearch check to bib id-identified urls.
- update logic around collection=circ query param in recordReg handler - I think this is what the desired behavior is, but could use an extra confirmation there.
- light refactor of tests to stub more cleanly
- new unit tests for new queryIsResearch method
nonword
reviewed
Apr 23, 2026
Member
nonword
left a comment
nonword
left a comment
There was a problem hiding this comment.
Thanks for the much nicer separation
| if (Array.isArray(collection) && collection.includes('circ')) { | ||
| return `${process.env.VEGA_HOST}/search/card?recordId=${bnum.replace(/\D/g, '')}` | ||
| const circCollection = Array.isArray(collection) && collection.includes('circ') | ||
| const { isResearch } = await requests.queryIsResearch(num, 'id') |
Member
There was a problem hiding this comment.
Can we skip doing the queryIsResearch when circCollection === true?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.