put format in an array to match what front end expects#468
Merged
charmingduchess merged 1 commit intomainfrom Mar 17, 2025
Merged
put format in an array to match what front end expects#468charmingduchess merged 1 commit intomainfrom
charmingduchess merged 1 commit intomainfrom
Conversation
nonword
approved these changes
Mar 17, 2025
Member
nonword
left a comment
nonword
left a comment
There was a problem hiding this comment.
We historically cast all data as arrays, even non-repeating values, just to remove uncertainty on the front-end. More recently, this rule has fallen off as we have some properties that are singular. If it's easier to cast it as an array here from the backend, then this is fine; If easier to update the front-end, that's also fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The front end is expecting format to be an object in an array. I assume we would like to continue that data structure? I personally feel that it is unnecessary but I do not feel strongly about it either way.