Light normalization preprocessing for browse terms#717
Merged
yossariano merged 1 commit intomainfrom Apr 15, 2026
Merged
Conversation
Contributor
yossariano
commented
Apr 14, 2026
yossariano
commented
- As pointed out by Nora, our Elasticsearch folding analyzers don't seem to account for certain characters, hence we see things like this which look identical but have an invisible character difference:
- Has results: https://www.nypl.org/research/research-catalog/browse/authors?q=Ki%C5%A1%2C%20Danilo%2C%201935-1989&search_scope=starts_with&sort=termLabel&sort_direction=asc
- No results: https://www.nypl.org/research/research-catalog/browse/authors?q=Kis%CC%8C%2C%20Danilo%2C%201935-1989&search_scope=starts_with
- This change adds extremely light normalization into the preprocessing for the query which addresses the above discrepancy.
danamansana
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.