Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
clarissarichard
requested review from
Toxiapo,
jackiequach,
kristojorg,
oliviawongnyc and
samanthaandrews
as code owners
samanthaandrews
requested changes
Mar 14, 2025
Collaborator
samanthaandrews
left a comment
samanthaandrews
left a comment
There was a problem hiding this comment.
just a few small changes. looks great!
playwright/tests/test.spec.ts
Outdated
| //await expect(page.getByRole('link', { name: 'Back' })).toBeVisible(); // does not work | ||
| //await expect(page.getByRole('paragraph', { name: 'Back' })).toBeVisible(); // does not work | ||
| //await expect(page.getByText('Back')).toBeVisible(); // works but could be found in epub | ||
| await expect(page.getByLabel('Return to Homepage')).toBeVisible(); // works |
Collaborator
There was a problem hiding this comment.
nice getByLabel is good because it also tests that the site is accessible
playwright/tests/test.spec.ts
Outdated
Comment on lines
+5
to
+7
| //await expect(page.getByRole('link', { name: 'Back' })).toBeVisible(); // does not work | ||
| //await expect(page.getByRole('paragraph', { name: 'Back' })).toBeVisible(); // does not work | ||
| //await expect(page.getByText('Back')).toBeVisible(); // works but could be found in epub |
Collaborator
There was a problem hiding this comment.
let's just delete these 3 lines
playwright/tests/test.spec.ts
Outdated
| import { test, expect } from '@playwright/test'; | ||
|
|
||
| test('Open moby-epub3', async ({ page }) => { | ||
| await page.goto('http://localhost:1234/html/moby-epub3'); |
Collaborator
There was a problem hiding this comment.
i think we can put http://localhost:1234 into the Playwright config file somewhere https://playwright.dev/docs/test-configuration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds Playwright to the web-reader repo and creates a test to open the direct link to an epub and verify that the Back button is visible.