Skip to content

Conversation

@NachoToast
Copy link
Owner

TryDissipateGasses and TryDiffuseGasses are private and only ever get called by GasGrid:Tick. Instead of patching them, having overhead on every cell on the map, and influencing the default tick that may rely on only vanilla gases being ticked you'd get better performance and compatibility by patching GasGrid:Tick and then just running your custom logic afterwards, preferably in a much smaller loop that doesn't tick all the cells without gases

This PR aims to achieve the first part of the above excerpt, moving the dissipation and diffusion methods to be internally called by a newly postfixed Tick method.

@NachoToast NachoToast self-assigned this Jul 12, 2023
@NachoToast NachoToast merged commit cfb0db5 into main Jul 21, 2023
@NachoToast NachoToast deleted the diffuse/density-modifications branch July 21, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants