feat(integrations): Add support for Dropbox sign #4019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces the Dropbox Sign OAuth integration, including detailed documentation for setup and usage. Key changes include: - New documentation files for Dropbox Sign OAuth, covering access requirements, setup instructions, and useful links. - Configuration for Dropbox Sign OAuth in the providers.yaml file, specifying authentication details and API endpoints. - Addition of a logo asset for Dropbox Sign OAuth. This integration allows users to authenticate and connect their applications with Dropbox Sign using OAuth, enhancing the overall capabilities of the Nango platform.
|
Your mrge subscription is currently inactive. Please reactivate your subscription to receive AI reviews and use mrge. |
bodinsamuel
approved these changes
May 12, 2025
…al asset Enhanced the Dropbox Sign OAuth documentation by updating the connection instructions for creating an app, including detailed steps for accessing the Developer Portal and enabling OAuth. Additionally, added a new visual asset (form.png) to improve user guidance.
bodinsamuel
suggested changes
May 13, 2025
TBonnin
force-pushed
the
master
branch
3 times, most recently
from
f519537 to
87a5092
Compare
hassan254-prog
added a commit
that referenced
this pull request
May 28, 2025
## Describe the problem and your solution - Some providers like [Dropbox sign OAuth](#4019), do not allow empty query parameters, such as `scope` which we automatically inject. - This PR introduces a flag `authorization_url_skip_undefined` that can be set to `true` for providers where we want to omit these undefined parameters from the authorization URL. <!-- Issue ticket number and link (if applicable) --> <!-- Testing instructions (skip if just adding/editing providers) --> <!-- Summary by @propel-code-bot --> --- This PR introduces a new configuration flag, `authorization_url_skip_empty`, in provider definitions, allowing certain OAuth providers to omit query parameters with empty or undefined values (e.g., `scope`) from the authorization URL. The update modifies the OAuth controller, provider type definition, and the schema validation to support this flag, aiming to improve compatibility with providers like Dropbox Sign that do not accept empty query parameters. **Key Changes:** • Added `authorization_url_skip_empty?: boolean` to provider types (`provider.ts`) • Extended provider JSON schema (`schema.json`) with the new boolean field • Modified OAuth controller logic (`oauth.controller.ts`) to remove entries with empty string values in the authorization URL when flag is enabled **Affected Areas:** • OAuth controller (`packages/server/lib/controllers/oauth.controller.ts`) • Provider configuration schema (`scripts/validation/providers/schema.json`) • Provider type definitions (`packages/types/lib/providers/provider.ts`) *This summary was automatically generated by @propel-code-bot*
| auth_mode: OAUTH2 | ||
| authorization_url: https://app.hellosign.com/oauth/authorize | ||
| token_url: https://app.hellosign.com/oauth/token | ||
| authorization_url_skip_empty: true |
Contributor
There was a problem hiding this comment.
Tested the flow with this recently added flag and it works well.
hassan254-prog
changed the title
bodinsamuel
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CONVERTED TO DRAFT SINCE NANGO DOESN'T YET SUPPORT COMPLETE REMOVAL OF THE SCOPE PARAM FROM THE URL WHICH CAUSES AN ERROR WHEN OBTAINING AUTHORIZATION.
This PR adds support for the Dropbox Sign OAuth integration, including documentation for setup and usage.
This PR introduces Dropbox Sign as a new OAuth2 provider within the Nango platform. It adds the necessary provider configuration (endpoints, OAuth parameters, and retry logic) in
providers.yaml, comprehensive documentation for setup and usage, and the provider's assets (including an SVG logo) to the documentation/UI. The documentation includes setup details, API requirements, and notes about production app approval, ensuring users have clear integration guidance.Key Changes:
• Added Dropbox Sign (HelloSign) OAuth2 configuration to
providers.yamlwith endpoints, proxy base URL, and retry mechanisms.• Created provider setup and usage documentation under
docs-v2/integrations/all/dropbox-sign.mdx, with embedded tooling and use-case snippets.• Registered new documentation entry for Dropbox Sign in the docs navigation via
docs-v2/mint.json.• Added Dropbox Sign SVG logo asset for UI representation.
Affected Areas:
• OAuth provider configuration (
providers.yaml)• Integration documentation (various
.mdxfiles,mint.json)• Webapp image assets
This summary was automatically generated by @propel-code-bot