Fix/sha 256#153
Merged
Merged
Conversation
…ove search functionality
…ployment and add test environment secret instructions
|
@Power70 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #97
PR: Replace placeholder WASM hash with SHA-256 in deploy flow
Issue: #97
Summary
This change replaces the placeholder rolling hash in the deploy flow with a real SHA-256 digest of the raw
.wasmbytes. The deploy output now uses Soroban-aligned terminology so developers can compare the local hash with the value reported by Stellar tooling.It also removes the last hardcoded secret-like test value from the repository. Secret validation tests now read
STARFORGE_TEST_SECRET_KEYfrom the environment at runtime.What Changed
src/commands/deploy.rsto compute the local WASM hash with SHA-256.tests/fixtures/minimal.wasm.src/commands/new.rsandsrc/utils/templates.rsso the workspace builds cleanly again.README.mdto document the SHA-256 deploy hash and the env-based test secret.Security Notes
The secret used by
src/utils/config.rstests is not generated or stored in the repository. It should be created externally and injected throughSTARFORGE_TEST_SECRET_KEYwhen running tests locally or in CI.Example:
Validation
cargo test test_valid_plain_secret_key -- --nocapturecargo testBoth commands pass when
STARFORGE_TEST_SECRET_KEYis set in the environment.