feat: enhance tx history with filtering, pagination, and memo decoding#84
Merged
Nanle-code merged 2 commits intoNanle-code:masterfrom Apr 28, 2026
Merged
Conversation
|
@Manuelshub Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
Author
|
@Nanle-code Please review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #33
Summary
The existing
starforge tx historycommand was minimal — no filtering, no pagination, and no transaction details. This PR enhances it with date range filtering, pagination support, memo decoding, and a--detailsflag for expanded output.Changes
src/commands/tx.rs--cursorflag for pagination using Horizon'spaging_token--after/--beforeflags for date range filtering (ISO 8601)--successfulflag to filter to successful transactions only--detailsflag to expand each row with source account and decoded memosrc/utils/horizon.rsTransactionRecordwithmemo,memo_type,source_account, andpaging_tokenfieldsTxFilterstruct to encapsulate filter parametersfetch_transactions_filtered()with cursor and client-side date/status filteringfetch_transactions()as a convenience wrapper for backward compatibilityUsage