Pythonic replacement for the mutable default for vertices argument of Volume class constructor#3159
Merged
stevengj merged 1 commit intoNanoComp:masterfrom Mar 2, 2026
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3159 +/- ##
==========================================
+ Coverage 73.81% 73.90% +0.09%
==========================================
Files 18 18
Lines 5423 5454 +31
==========================================
+ Hits 4003 4031 +28
- Misses 1420 1423 +3
🚀 New features to boost your workflow:
|
vertices argument of Voume class constructorvertices argument of Volume class constructor
stevengj
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
verticesargument of theVolumeclass constructor uses a mutable default (a list). While this is not a functional bug since the list object is never mutated asverticesis a throwaway parameter used only to computecenterandsize, it is a code smell as it would fail a linter likepylintorruffwithB006/W0102. This PR replaces the mutable default with an idiomatic Python convention –Noneas a sentinel for "no value provided" is universally understood.