Fix no-MPB stub for get_eigenmode to match updated declaration#3202
Merged
stevengj merged 1 commit intoNanoComp:masterfrom Apr 17, 2026
Merged
Conversation
get_eigenmode to match updated declaration
7bc6176 to
333cb65
Compare
…ameters to get_eigenmode
333cb65 to
4e7e632
Compare
Contributor
Author
|
Tagging @stevengj. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #3167 added
cache_dispersiveandcache_frequencyparameters tofields::get_eigenmodeinmeep.hpp, but only updated the no-MPB stub forget_eigenmode_coefficients. The get_eigenmode stub was missed. This causes a compile error when building without MPB (e.g., the ASAN and UBSAN CI jobs):This PR adds the two missing parameters to the no-MPB stub signature.
This PR was tested against the sanitizers CI here.