Skip to content

Fix no-MPB stub for get_eigenmode to match updated declaration#3202

Merged
stevengj merged 1 commit intoNanoComp:masterfrom
Luochenghuang:fix-no-mpb-get-eigenmode-stub
Apr 17, 2026
Merged

Fix no-MPB stub for get_eigenmode to match updated declaration#3202
stevengj merged 1 commit intoNanoComp:masterfrom
Luochenghuang:fix-no-mpb-get-eigenmode-stub

Conversation

@Luochenghuang
Copy link
Copy Markdown
Contributor

@Luochenghuang Luochenghuang commented Apr 17, 2026

PR #3167 added cache_dispersive and cache_frequency parameters to fields::get_eigenmode in meep.hpp, but only updated the no-MPB stub for get_eigenmode_coefficients. The get_eigenmode stub was missed. This causes a compile error when building without MPB (e.g., the ASAN and UBSAN CI jobs):

mpb.cpp:1075:15: error: out-of-line definition of 'get_eigenmode' does not match any declaration in 'meep::fields'
 1075 | void *fields::get_eigenmode(double frequency, direction d, const volume where, const volume eig_vol,
      |               ^~~~~~~~~~~~~

This PR adds the two missing parameters to the no-MPB stub signature.
This PR was tested against the sanitizers CI here.

@Luochenghuang Luochenghuang changed the title Fix no-MPB stub for get_eigenmode to match updated declaration Fix no-MPB stub for get_eigenmode to match updated declaration Apr 17, 2026
@Luochenghuang Luochenghuang force-pushed the fix-no-mpb-get-eigenmode-stub branch from 7bc6176 to 333cb65 Compare April 17, 2026 19:56
@Luochenghuang Luochenghuang force-pushed the fix-no-mpb-get-eigenmode-stub branch from 333cb65 to 4e7e632 Compare April 17, 2026 19:59
@Luochenghuang Luochenghuang marked this pull request as ready for review April 17, 2026 20:41
@Luochenghuang
Copy link
Copy Markdown
Contributor Author

Luochenghuang commented Apr 17, 2026

Tagging @stevengj.

@stevengj stevengj merged commit 2d14125 into NanoComp:master Apr 17, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants