Remove flake8#3215
Merged
stevengj merged 1 commit intoNanoComp:masterfrom May 8, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Python command-line utility
flake8for ensuring code consistency is currently not doing anything as there is no pre-commit hook for it. It only runs if someone remembers to invoke it manually. On top of that, Black already handles the formatting/style rules (E/W codes). The.flake8config ignores most codes that would overlap (E501,W503,E203).What's left that Black doesn't cover:
pyflakes): unused imports, undefined names, redefined variables. These catch real bugs - this is the only genuinely useful part.complexity): set ot 57 (which is extremely high; relaxed projects use 15-20), so effectively disabled.bugbear): selected in the config, butflake8-bugbearisn't installed, so these do nothing..flake8can be removed without meaningful impact to readability. Black already owns formatting. The one important thing we lose ispyflakes-style error detection (unused imports, undefined names), but sinceflake8isn't wired intopre-commit, we are not getting that benefit today.