Skip to content

Remove flake8#3215

Merged
stevengj merged 1 commit intoNanoComp:masterfrom
oskooi:remove_flake8
May 8, 2026
Merged

Remove flake8#3215
stevengj merged 1 commit intoNanoComp:masterfrom
oskooi:remove_flake8

Conversation

@oskooi
Copy link
Copy Markdown
Collaborator

@oskooi oskooi commented May 8, 2026

The Python command-line utility flake8 for ensuring code consistency is currently not doing anything as there is no pre-commit hook for it. It only runs if someone remembers to invoke it manually. On top of that, Black already handles the formatting/style rules (E/W codes). The .flake8 config ignores most codes that would overlap (E501, W503, E203).

What's left that Black doesn't cover:

  • F-codes (pyflakes): unused imports, undefined names, redefined variables. These catch real bugs - this is the only genuinely useful part.
  • C-codes (complexity): set ot 57 (which is extremely high; relaxed projects use 15-20), so effectively disabled.
  • B-codes (bugbear): selected in the config, but flake8-bugbear isn't installed, so these do nothing.

.flake8 can be removed without meaningful impact to readability. Black already owns formatting. The one important thing we lose is pyflakes-style error detection (unused imports, undefined names), but since flake8 isn't wired into pre-commit, we are not getting that benefit today.

@stevengj stevengj merged commit 6d8e224 into NanoComp:master May 8, 2026
4 checks passed
@oskooi oskooi deleted the remove_flake8 branch May 8, 2026 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants