Replace #646 get_source_slice parsing with components#652
Merged
stevengj merged 17 commits intoNanoComp:masterfrom Jan 7, 2019
ChristopherHogan:pr_646
Merged
Replace #646 get_source_slice parsing with components#652stevengj merged 17 commits intoNanoComp:masterfrom ChristopherHogan:pr_646
stevengj merged 17 commits intoNanoComp:masterfrom
ChristopherHogan:pr_646
Conversation
…scheme inclusion from makefile.am
bencbartlett
pushed a commit
to bencbartlett/meep
that referenced
this pull request
Sep 9, 2021
…mp#652) * updates * updates * updates * updates * updates * updates * updates * updates * source_slice * updates * removed overlap with geometric_object_source branch, uncommented out scheme inclusion from makefile.am * Replace get_source_slice parsing with just component * Update docs * no need for slice_component!=Permeability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #646.
get_source_slicereturns a complex array based on thecomponentpassed to it.vecandivecmember initialization lists (C++ 11 feature) with aninit_tfunction called in the constructors.python/examples/object_source.pybecause it seemed to rely on features from PR Geometric object source #635.TODO: I included a sanity test to make sure
sim.get_source_sliceis callable, but we need a better test.@stevengj @oskooi @HomerReid