feat: add loader given env to config registry#246
Merged
Conversation
github-actions
bot
added
packages:common
Exeloo
force-pushed
the
feat/add-env-handling
branch
from
0b2573e to
564c71a
Compare
MartinFillon
approved these changes
Mar 7, 2026
Contributor
MartinFillon
left a comment
MartinFillon
left a comment
There was a problem hiding this comment.
Why putting everything uppercase ?
Member
Author
|
Because now it's env variables. And config must have thé same name as the variable in .env |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Handle env from main to allow loader to pass env variables
How do you test this PR?