Allow for node version 0.6.17#29
Closed
TheDigitalNinja wants to merge 5 commits intoNarrativeScience-old:masterfrom
Closed
Allow for node version 0.6.17#29TheDigitalNinja wants to merge 5 commits intoNarrativeScience-old:masterfrom
TheDigitalNinja wants to merge 5 commits intoNarrativeScience-old:masterfrom
Conversation
|
Could someone please merge this pull request or do the needful to support the latest version of nodejs. |
Collaborator
|
I eased the upper bound version restriction in v0.2.7, just tested it against 0.6.19. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: #26
Most environments are switching to node 0.6.17 after the security vulnerability found in http. I updated package.json to allow for this version. It probably would be safe to even allow node > 0.7.0
This is my first ever pull request so please let me know if I need to do anything else or if I did something wrong.