Skip to content

use project dir in getGitVersion#2

Merged
MikaelUmaN merged 1 commit intoNasdaq:masterfrom
b-dean:project-dir
Mar 7, 2016
Merged

use project dir in getGitVersion#2
MikaelUmaN merged 1 commit intoNasdaq:masterfrom
b-dean:project-dir

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Feb 10, 2016

Rather than running git describe in the current working dir, run it in
the directory of the gradle project. This allows projects that come from
git submodules to use the versions from their repo's tags.

rather than running `git describe` in the current working dir, run it in
the directory of the gradle project. This allows projects that come from
git submodules to use the versions from their tags.
@ghost
Copy link
Copy Markdown
Author

ghost commented Feb 10, 2016

I have not yet signed the Cinnober CLA, but I'll send it to you soon.

@mbrannstrom
Copy link
Copy Markdown
Contributor

Zombiedev, have you signed the CLA and heard anything from Cinnober yet?

I'm not working at Cinnober anymore but I think this should be merged and released as a bug-fix, i.e. as version 2.2.2.

@ghost
Copy link
Copy Markdown
Author

ghost commented Feb 26, 2016

@mbrannstrom, I just emailed it to them.

I don't know how active this project is or when they'll merge this PR, but you can always do something like this in the meantime:

buildscript {
    repositories {
        mavenCentral()
        jcenter()
        maven { url "https://jitpack.io" }
    }

    dependencies {
        classpath "com.github.zombiedev:semver-git:98f7bb63b0"
    }
}

MikaelUmaN added a commit that referenced this pull request Mar 7, 2016
use project dir in getGitVersion
@MikaelUmaN MikaelUmaN merged commit d79a292 into Nasdaq:master Mar 7, 2016
@MikaelUmaN
Copy link
Copy Markdown
Contributor

Thank you for your contribution. I will try to find out who are on the mailing list aforementioned and why no response was sent to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants