Skip to content

Ci/typecheck comment fix#59

Merged
Nat3z merged 4 commits intofeat/add-project-wide-type-checkfrom
ci/typecheck-comment
Feb 3, 2026
Merged

Ci/typecheck comment fix#59
Nat3z merged 4 commits intofeat/add-project-wide-type-checkfrom
ci/typecheck-comment

Conversation

@Nat3z
Copy link
Owner

@Nat3z Nat3z commented Feb 3, 2026

No description provided.

@vercel
Copy link

vercel bot commented Feb 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
open-game-installer-web Ready Ready Preview, Comment Feb 3, 2026 9:24pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 3, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ci/typecheck-comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Nat3z Nat3z merged commit 653b1df into feat/add-project-wide-type-check Feb 3, 2026
2 of 3 checks passed
@Nat3z Nat3z deleted the ci/typecheck-comment branch February 3, 2026 21:24
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typecheck Failed

Please fix the following type errors:

�[33mWarn�[39m: Unused CSS selector ".error-container"
  �[35m.error-container�[36m {
  .error-text {�[39m
�[33mWarn�[39m: Unused CSS selector ".error-text"
  �[35m.error-text�[36m {
�[36m  .error-container {
�[36m  .error-text {
�[36m  .status-error {
�[36m  .status-errored {
�[36m  .status-badge.error {
�[36m  .status-badge.errored {
�[36m  .error-time {
�[36m  .failed-setup-error {
�[36m  .error-message {
�[36m            // Remove from loading set even on error
�[36m          console.error(ex);
�[31mError�[39m: Unused '@ts-expect-error' directive. (ts)
      �[35m// @ts-expect-error - options is a valid property for a string option if a choice.�[36m
�[31mError�[39m: Unused '@ts-expect-error' directive. (ts)
        �[35m// @ts-expect-error - options is a valid property for a string option if a choice.�[36m
�[36m        } catch (error) {
          console.warn(`Failed to load catalog for addon ${addon.�[35mid�[36m}:`, error);
�[36m              // Remove from loading set even on error
              console.error(`Error searching addon ${addon.�[35mname�[36m}:`, error);
�[31msvelte-check found 133 errors and 371 warnings in 42 files
�[39merror: script "check" exited with code 1

Nat3z added a commit that referenced this pull request Feb 4, 2026
* ci: add project-wide typecheck workflow for main and PRs

* Remove duplicate 'typecheck' script from package.json

* Fix formatting in package.json for release-beta script

* fix(typecheck): resolve CI typecheck failures

* fix(typecheck): fix addonName field mapping in RequestService

* fix(typecheck): resolve Svelte type errors

* fix(typecheck): resolve Svelte type errors and improve tsconfig module resolution

* fix(typecheck): resolve all TypeScript module resolution and top-level await errors

* ci: add typecheck comment posting script and GitHub Actions workflow

* docs: add typecheck script documentation

* Delete .github/workflows/typecheck.yml

* Ci/typecheck comment (#58)

* ci: add typecheck and comment automation for PR request-changes review

* ci: improve typecheck-comment workflow with better error handling and permissions

---------

Co-authored-by: ClawBot <natiaclawdbot@gmail.com>

* Enable concurrency for typecheck workflow

Add concurrency settings to typecheck workflow

* Ci/typecheck comment fix (#59)

* ci: add typecheck and comment automation for PR request-changes review

* ci: improve typecheck-comment workflow with better error handling and permissions

* ci: simplify typecheck workflow - combine comment logic inline and run only on PRs

---------

Co-authored-by: ClawBot <natiaclawdbot@gmail.com>

* fix(ci): address CodeRabbit review - improve typecheck workflow and fix type issues

- Fix duplicate key in Debug.svelte (t -> t2) and remove obsolete @ts-expect-error
- Improve typecheck.yml: add contents:read permission, restrict to main branch
- Fix typecheck-comment.yml condition for non-success runs
- Fix real-debrid tsconfig: remove DOM lib, add types:[node]
- Clean up unused CSS in CommunityAddonsList.svelte

* ci: combine typecheck and comment workflows

- Combine typecheck logic and PR commenting into a single workflow (typecheck.yml)
- Set PR branch filter to "**" as a reference to the flex repo configuration
- Remove redundant typecheck-comment.yml workflow

* ci: fix typecheck reporting logic and match flex pattern

* ci: verify gpg signing with new key

* ci: strip ansi codes from typecheck results

* Delete TYPECHECK_README.md

* Delete post-typecheck-comment.sh

* chore: improve typecheck workflow (main-only, pipefail, error regex, review truncation)

* Update typecheck.yml

* Delete scripts/typecheck-with-comment.sh

---------

Co-authored-by: Nat3z <66748576+Nat3z@users.noreply.github.com>
Co-authored-by: Fix Bot <fix-bot@openclaw.local>
Co-authored-by: Clawd <clawd@openclaw.ai>
Nat3z added a commit that referenced this pull request Feb 4, 2026
commit 3ddfeec
Author: nat-openclaw <natiaclawdbot@gmail.com>
Date:   Wed Feb 4 10:51:53 2026 -0800

    feat: Add project-wide typecheck to CI (#57)

    * ci: add project-wide typecheck workflow for main and PRs

    * Remove duplicate 'typecheck' script from package.json

    * Fix formatting in package.json for release-beta script

    * fix(typecheck): resolve CI typecheck failures

    * fix(typecheck): fix addonName field mapping in RequestService

    * fix(typecheck): resolve Svelte type errors

    * fix(typecheck): resolve Svelte type errors and improve tsconfig module resolution

    * fix(typecheck): resolve all TypeScript module resolution and top-level await errors

    * ci: add typecheck comment posting script and GitHub Actions workflow

    * docs: add typecheck script documentation

    * Delete .github/workflows/typecheck.yml

    * Ci/typecheck comment (#58)

    * ci: add typecheck and comment automation for PR request-changes review

    * ci: improve typecheck-comment workflow with better error handling and permissions

    ---------

    Co-authored-by: ClawBot <natiaclawdbot@gmail.com>

    * Enable concurrency for typecheck workflow

    Add concurrency settings to typecheck workflow

    * Ci/typecheck comment fix (#59)

    * ci: add typecheck and comment automation for PR request-changes review

    * ci: improve typecheck-comment workflow with better error handling and permissions

    * ci: simplify typecheck workflow - combine comment logic inline and run only on PRs

    ---------

    Co-authored-by: ClawBot <natiaclawdbot@gmail.com>

    * fix(ci): address CodeRabbit review - improve typecheck workflow and fix type issues

    - Fix duplicate key in Debug.svelte (t -> t2) and remove obsolete @ts-expect-error
    - Improve typecheck.yml: add contents:read permission, restrict to main branch
    - Fix typecheck-comment.yml condition for non-success runs
    - Fix real-debrid tsconfig: remove DOM lib, add types:[node]
    - Clean up unused CSS in CommunityAddonsList.svelte

    * ci: combine typecheck and comment workflows

    - Combine typecheck logic and PR commenting into a single workflow (typecheck.yml)
    - Set PR branch filter to "**" as a reference to the flex repo configuration
    - Remove redundant typecheck-comment.yml workflow

    * ci: fix typecheck reporting logic and match flex pattern

    * ci: verify gpg signing with new key

    * ci: strip ansi codes from typecheck results

    * Delete TYPECHECK_README.md

    * Delete post-typecheck-comment.sh

    * chore: improve typecheck workflow (main-only, pipefail, error regex, review truncation)

    * Update typecheck.yml

    * Delete scripts/typecheck-with-comment.sh

    ---------

    Co-authored-by: Nat3z <66748576+Nat3z@users.noreply.github.com>
    Co-authored-by: Fix Bot <fix-bot@openclaw.local>
    Co-authored-by: Clawd <clawd@openclaw.ai>

commit 561b07d
Author: Nat3z <66748576+Nat3z@users.noreply.github.com>
Date:   Tue Feb 3 09:49:31 2026 -0800

    chore(dependencies): update @types/node version and add typecheck script
Nat3z added a commit that referenced this pull request Feb 9, 2026
…#64)

* Add own Games (issue #18)

* SteamDeck: Game Mode Integration (issue #14)

* docs: update README.md

* fix(review): directly from `plan/PLAN.md`.

* fix(review): type host as string in all-debrid add-magnet handler

* fix(review): guard main window usage and declare addTorrent can return null

* feat(alldebrid): fixed all debrid logo

* ci: add project-wide typecheck workflow for main and PRs

* Remove duplicate 'typecheck' script from package.json

* Fix formatting in package.json for release-beta script

* fix(typecheck): resolve CI typecheck failures

* fix(typecheck): fix addonName field mapping in RequestService

* fix(typecheck): resolve Svelte type errors

* fix(typecheck): resolve Svelte type errors and improve tsconfig module resolution

* fix(typecheck): resolve all TypeScript module resolution and top-level await errors

* ci: add typecheck comment posting script and GitHub Actions workflow

* docs: add typecheck script documentation

* Delete .github/workflows/typecheck.yml

* Ci/typecheck comment (#58)

* ci: add typecheck and comment automation for PR request-changes review

* ci: improve typecheck-comment workflow with better error handling and permissions

---------

Co-authored-by: ClawBot <natiaclawdbot@gmail.com>

* Enable concurrency for typecheck workflow

Add concurrency settings to typecheck workflow

* Ci/typecheck comment fix (#59)

* ci: add typecheck and comment automation for PR request-changes review

* ci: improve typecheck-comment workflow with better error handling and permissions

* ci: simplify typecheck workflow - combine comment logic inline and run only on PRs

---------

Co-authored-by: ClawBot <natiaclawdbot@gmail.com>

* fix(ci): address CodeRabbit review - improve typecheck workflow and fix type issues

- Fix duplicate key in Debug.svelte (t -> t2) and remove obsolete @ts-expect-error
- Improve typecheck.yml: add contents:read permission, restrict to main branch
- Fix typecheck-comment.yml condition for non-success runs
- Fix real-debrid tsconfig: remove DOM lib, add types:[node]
- Clean up unused CSS in CommunityAddonsList.svelte

* ci: combine typecheck and comment workflows

- Combine typecheck logic and PR commenting into a single workflow (typecheck.yml)
- Set PR branch filter to "**" as a reference to the flex repo configuration
- Remove redundant typecheck-comment.yml workflow

* ci: fix typecheck reporting logic and match flex pattern

* ci: verify gpg signing with new key

* ci: strip ansi codes from typecheck results

* Delete TYPECHECK_README.md

* Delete post-typecheck-comment.sh

* chore: improve typecheck workflow (main-only, pipefail, error regex, review truncation)

* fix(review): catch startDownload errors in lifecycle, reset button, and add JSDoc

* Squashed commit of the following:

commit 3ddfeec
Author: nat-openclaw <natiaclawdbot@gmail.com>
Date:   Wed Feb 4 10:51:53 2026 -0800

    feat: Add project-wide typecheck to CI (#57)

    * ci: add project-wide typecheck workflow for main and PRs

    * Remove duplicate 'typecheck' script from package.json

    * Fix formatting in package.json for release-beta script

    * fix(typecheck): resolve CI typecheck failures

    * fix(typecheck): fix addonName field mapping in RequestService

    * fix(typecheck): resolve Svelte type errors

    * fix(typecheck): resolve Svelte type errors and improve tsconfig module resolution

    * fix(typecheck): resolve all TypeScript module resolution and top-level await errors

    * ci: add typecheck comment posting script and GitHub Actions workflow

    * docs: add typecheck script documentation

    * Delete .github/workflows/typecheck.yml

    * Ci/typecheck comment (#58)

    * ci: add typecheck and comment automation for PR request-changes review

    * ci: improve typecheck-comment workflow with better error handling and permissions

    ---------

    Co-authored-by: ClawBot <natiaclawdbot@gmail.com>

    * Enable concurrency for typecheck workflow

    Add concurrency settings to typecheck workflow

    * Ci/typecheck comment fix (#59)

    * ci: add typecheck and comment automation for PR request-changes review

    * ci: improve typecheck-comment workflow with better error handling and permissions

    * ci: simplify typecheck workflow - combine comment logic inline and run only on PRs

    ---------

    Co-authored-by: ClawBot <natiaclawdbot@gmail.com>

    * fix(ci): address CodeRabbit review - improve typecheck workflow and fix type issues

    - Fix duplicate key in Debug.svelte (t -> t2) and remove obsolete @ts-expect-error
    - Improve typecheck.yml: add contents:read permission, restrict to main branch
    - Fix typecheck-comment.yml condition for non-success runs
    - Fix real-debrid tsconfig: remove DOM lib, add types:[node]
    - Clean up unused CSS in CommunityAddonsList.svelte

    * ci: combine typecheck and comment workflows

    - Combine typecheck logic and PR commenting into a single workflow (typecheck.yml)
    - Set PR branch filter to "**" as a reference to the flex repo configuration
    - Remove redundant typecheck-comment.yml workflow

    * ci: fix typecheck reporting logic and match flex pattern

    * ci: verify gpg signing with new key

    * ci: strip ansi codes from typecheck results

    * Delete TYPECHECK_README.md

    * Delete post-typecheck-comment.sh

    * chore: improve typecheck workflow (main-only, pipefail, error regex, review truncation)

    * Update typecheck.yml

    * Delete scripts/typecheck-with-comment.sh

    ---------

    Co-authored-by: Nat3z <66748576+Nat3z@users.noreply.github.com>
    Co-authored-by: Fix Bot <fix-bot@openclaw.local>
    Co-authored-by: Clawd <clawd@openclaw.ai>

commit 561b07d
Author: Nat3z <66748576+Nat3z@users.noreply.github.com>
Date:   Tue Feb 3 09:49:31 2026 -0800

    chore(dependencies): update @types/node version and add typecheck script

* chore: updated bun.lockb

* fix(review): add JSDoc to AllDebrid handler and download lifecycle

* fix(types): fixed type errors

* fix(typechecks): added all-debrid to typecheck-deps

* fix(review): run build:ogiaddon before check and type AllDebrid stream as IncomingMessage

* fix(typecheck): resolve all-debrid-js type errors and tsconfig issues

* chore: remove typecheck-with-comment script as it is no longer needed

* fix(typecheck): implement request guards, navigation security, and startDownload logic

* fix(ci): add electron to root devDependencies and update lockfile

* fix(electron): wrap startup tasks in try/finally for splash cleanup

* fix(frontend): ensure download button is reset and add timeouts to polling

* chore(all-debrid): add MIT license

* fix(electron): implement total stream timeout and size cap for AllDebrid torrents

* feat(library): implement add own games feature

* fix: address PR reviews and failing type checks

- Added 'addManualGame' to Window.electronAPI and preload.mts to fix type errors.
- Implemented button state reset on early-return paths in lifecycle.ts.
- Added 10-minute timeout and improved error handling in RealDebridService.ts polling loop.

* fix(pr-review): address PR reviews and fix type errors

- Fix duplicate 'addManualGame' in preload.mts
- Add 10-minute timeout to RealDebridService polling loop and ensure interval is stopped on error
- Refactor download services to consistently throw errors for centralized button resetting
- Clean up unused imports and variables in frontend services

* fix(typecheck): remove unused resolvedButton variable from RealDebridService

* Add automatic approval review when typecheck passes

* Apply suggestions from code review

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* refactor: apply code review feedback

- Remove manual game system (AddGameModal and related handlers)
- Fix EmptyService to run download logic regardless of button presence
- Fix TorrentService spread order to prevent property overwriting
- Guard process-wide listeners in main.ts with idempotent flag
- Add helper function for redistributable installation

* refactor: remove AddGameModal from LibraryView

- Eliminated the AddGameModal component and its associated event handler to streamline the LibraryView.

* fix(ci): avoid false positives in typecheck workflow

* fix(ci): avoid false positives in typecheck workflow

* refactor: address PR review comments

- fix(electron): handle macOS reactivation and single-window flow correctly
- fix(types): export AllDebridTorrentInfo and use correct imports in global.d.ts
- fix(downloads): improve error handling and button state reset in TorrentService and lifecycle
- fix(types): update BaseService signature to allow nullable event

* Address PR comments: Fix TorrentService path, use svelte/store get(), improve EmptyService typing

* Address PR comments: Improve Torbox polling safety and clean up debug logs

* fix: fixed all errors

* Fix missing torrent_id references

* fix(review): ensure splash window cleanup and remove unused variables

* fix(review): allow null event parameter in download service methods

* fix(review): improve button validation logic and error messages in download services

- DirectService: Remove redundant event null check, rely on instanceof validation
- RealDebridService: Remove unused button validation in startDownload; split error messages to distinguish missing name vs downloadURL
- TorboxService: Capture and restore button state (text + disabled) in try/finally block

* fix(review): apply button validation and error message fixes to all download services

- AllDebridService: Remove unused button validation; split error messages for missing name vs downloadURL
- PremiumizeService: Capture and restore button state (text + disabled) in try/finally block

This completes the review fixes across all download service implementations.

* fix(review): improve download button state management and type safety

* fix(review): improve error handling and code quality in handlers

* fix(review): add IPC handler and preload API for adding manual games to library

* fix(review): harden debrid services, fix config keys, remove debug logs

* Revert "fix(review): harden debrid services, fix config keys, remove debug logs"

This reverts commit dab4462.

* fix: fixed all-debrid integration entirely.

* fix: enhance addon installation process with URL validation and improve error handling

- Added validation for git URL format before cloning addons.
- Switched from exec to execFile for better command execution and error handling in the addon manager.

* fix: address security and logic issues across multiple handlers

- handler.addon.ts: Fix shell injection in git clone, improve update flow promise handling
- handler.app.ts: Add path validation to prevent directory traversal in get-local-image
- handler.ddl.ts: Fix PARALLEL_CHUNK_COUNT division by zero, fix status merging issue
- handler.fs.ts: Fix RAR/ZIP extraction promise handling to prevent double-settling
- handler.oobe.ts: Fix git installer config filename mismatch
- handler.realdebrid.ts: Fix fs.unlinkSync with undefined path, add proper cleanup
- main.ts: Fix cleanup order after app.quit to prevent premature termination
- manager.addon.ts: Add try-catch for addon.json read and JSON parsing

* fix: security and logic issues across multiple handlers

- Fix git clone shell injection in handler.addon.ts (use spawn with args)
- Add path validation in handler.app.ts to prevent path traversal
- Fix division-by-zero in handler.ddl.ts (ensure PARALLEL_CHUNK_COUNT >= 1)
- Fix promise double-settling in handler.fs.ts (RAR/ZIP extraction)
- Fix config filename mismatch in handler.oobe.ts
- Fix undefined path cleanup in handler.realdebrid.ts
- Fix cleanup timing and handler re-registration in main.ts
- Add error handling in manager.addon.ts for missing/malformed configs
- Fix migration eligibility logic in migrations.ts
- Fix message handling in AddonConnection.ts (use Map instead of recursive once)
- Add null-safe checks in api/addons.ts
- Fix promise settlement in startup.ts
- Fix basename offset bug in fs.ts
- Fix folder deletion logic in persistence.ts
- Fix stale ID in restart.ts catch block
- Add path sanitization in DirectService.ts
- Fix FormData serialization and config namespace in PremiumizeService.ts
- Fix null response handling in RequestService.ts
- Fix retry loop logic in failedSetups.ts

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix: resolve typecheck errors and lint warnings

- Fix type mismatch in RequestService.ts (null vs undefined)
- Fix scoping of newDownloadId in restart.ts
- Add property check for filename in persistence.ts
- Fix missing reject in handler.fs.ts promise
- Fix type assignment for 'merging' status in handler.ddl.ts
- Clean up unused variables in AddonConnection.ts and handler.addon.ts

Co-authored-by: Cursor <cursoragent@cursor.com>

* feat(workflows): add to typecheck an approval by github

---------

Co-authored-by: Nat3z <66748576+Nat3z@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: nat-openclaw <natiaclawdbot@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants