Conversation
Co-authored-by: Matt Steen <MatthewSteen@users.noreply.github.com>
TShapinsky
left a comment
There was a problem hiding this comment.
Looks good, we could also consider incorporating or linking to python-dotenv which automatically brings in a .env file as environment variables https://pypi.org/project/python-dotenv/
TShapinsky
left a comment
There was a problem hiding this comment.
Looks good to me once tests pass and it's merged
|
|
@MatthewSteen re-pinging this. |
|
@haneslinger I think this just needs some brief documentation about the BASH requirement to run on Windows. See my comments and suggestions above, specifically #256 (comment).
|
|
@MatthewSteen Oh, yes, thank you. Would you be able to add that? Do you want it in this PR? |
|
@haneslinger I added a note for windows users, which I think is sufficient for now. Take a look and merge when ready. |
We dont need this anymore, we've got
.env